Player Form module

[3hills]

--------------------------------------------------
Topic Transfered from old forum
--------------------------------------------------
Whether this a bug or not, I find it confusing and am sure players would find it confusing too.

The "Player Form" module allows for admin to set the number of matchdays over which the player form is measured. But the matchday measure uses fixture days rather than results days.

As a consequence, if I set the module to reflect 2 matchdays, then the table displays the top players over the past two matchdays ... so far, so good.
But, if I then enter & publish the next matchday fixtures, the table changes to reflect player performances over two matchdays, one of which has yet to be played, so effectively the table is showing player performances from just one matchday ... until the results have been entered for the new date, at which point the table will change again to reflect the new results.

If the table was compiled from the most recent results matchdays, the table would change just once, when results are entered and published.

As it stands the table changes twice for each matchday, once when results are added, then again when the next fixtures are published.

Buddy

[3hills]

--------------------------------------------------
Topic Transfered from old forum
--------------------------------------------------
nice we didn't thought about that issue, thank you for letting us know,

here is a quick fix until we release an update

edit the file

<joomla directory>/modules/mod_masterleaguepro_playerform/helper.php
~ line 32

from :

$query="SELECT id ".
" FROM `#__masterleaguepro_matchday` ".
" WHERE season_id=$season ".
" ORDER BY `date` DESC,id DESC ".
" LIMIT 0 ,". $forMatchdays ;

to

$query="SELECT id
FROM `#__masterleaguepro_matchday`
WHERE season_id=$season AND id IN (SELECT DISTINCT matchday_id FROM `#__masterleaguepro_match` WHERE `status`=1)
ORDER BY `date` DESC,id DESC
LIMIT 0 ,$forMatchdays";

[Buddy]

One further detail could do with fixing.
To set up the Player Form module, you need to specify the season and the league detail.
If you have more than one season and carry the league name over to each new season (which would be normal?), this module just lists identical league names without reference to WHICH season each is associated with.

The Top Players module does it exactly right, listing the league name (and associated season in brackets) so you can easily select the right one.

[kostas]

We found the problem , there was an issue on the modules for Joomla 3.x that uses the "chosen select input" we will fix the issue on the modules soon. Normally the behavior of the module would filter the leagues by the season you selected.